Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-24.2: workload/schemachange: turn on exec logging for all statements #137810

Merged
merged 3 commits into from
Jan 6, 2025
Merged

release-24.2: workload/schemachange: turn on exec logging for all statements #137810

merged 3 commits into from
Jan 6, 2025

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 20, 2024 •
edited by rafiss
Loading

Backport 3/3 commits from #137774 on behalf of @rafiss.

/cc @cockroachdb/release

workload: log full stack trace of error on failure

workload/schemachange: make ErrorState implement Cause()

This will make the error formatting work more conventionally.

workload/schemachange: turn on exec logging

This will help us see exactly which statements were executed by the
workload, including helper queries.

Epic: None
Release note: None

Release justification: test only change

@rafiss
workload: log full stack trace of error on failure
849fc90 
Release note: None
@rafiss
workload/schemachange: make ErrorState implement Cause()
a446c25 
This will make the error formatting work more conventionally.

Release note: None
@rafiss
workload/schemachange: turn on exec logging
26fb787 
This will help us see exactly which statements were executed by the
workload, including helper queries.

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.2-137774 branch from 778e179 to 26fb787 Compare December 20, 2024 06:58
@blathers-crl blathers-crl bot requested a review from a team as a code owner December 20, 2024 06:58
@blathers-crl blathers-crl bot requested review from sambhav-jain-16 and csgourav and removed request for a team December 20, 2024 06:58
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 20, 2024
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Dec 20, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 20, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

fqazi
fqazi approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @csgourav, @sambhav-jain-16, and @shailendra-patel)

@rafiss rafiss merged commit f8beb12 into release-24.2 Jan 6, 2025
19 of 20 checks passed
@rafiss rafiss deleted the blathers/backport-release-24.2-137774 branch January 6, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fqazi fqazi fqazi approved these changes

@sambhav-jain-16 sambhav-jain-16 Awaiting requested review from sambhav-jain-16 sambhav-jain-16 is a code owner automatically assigned from cockroachdb/test-eng

@csgourav csgourav Awaiting requested review from csgourav csgourav is a code owner automatically assigned from cockroachdb/test-eng

@shailendra-patel shailendra-patel Awaiting requested review from shailendra-patel

Assignees

@rafiss rafiss

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @fqazi @rafiss